Introduce major, minor and micro aliases to Version#225
Introduce major, minor and micro aliases to Version#225pradyunsg merged 1 commit intopypa:masterfrom
Conversation
|
I'm not sure I agree with the the behavior here. A version like I think I would expect |
d6e7963 to
696fc7a
Compare
Thanks for the review. Adjusted accordingly. |
|
@fridex do note that CI failed. |
|
Since these names are not the same as SemVer, I'm pretty sure that wouldn't be a source of confusion when using this API. Also, I don't think the PEP endorses using these names -- that's not a reason to avoid adding these, but I don't think we should view the use for explanation as "this should definitely exist as functionality in All that said, I'm on board for adding these aliases since they follow a common/clear convention, won't be a big maintenance burden, are unambiguous and useful for end users. Thanks for suggesting this feature and filing this PR @fridex! ^>^ |
696fc7a to
f1b2b22
Compare
Thanks for pointing it out, I missed it. Tests are green now.
Thanks for the review. I adjusted the commit message not to mention PEP explicitly. |
Well, any reason not to add |
I've added also |
1988d11 to
f1b2b22
Compare
Sure, I've just opened a separate PR which depends on this one in #229. PTAL |
|
(@brettcannon I have assumed that you're ambivalent to this change, lemme know if you're opposed to this) |
No description provided.